From 1b07818e6a8f90fc598a8df1e252df41b0416766 Mon Sep 17 00:00:00 2001 From: "docelic@crystallabs.io" Date: Fri, 3 May 2019 17:23:54 +0000 Subject: [PATCH] Improve save_config() FossilOrigin-Name: 99d62ede397dea67cc9f7d6b5f4b6e3c8159a693c4dff023abac21440a72e486 --- shelldap | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/shelldap b/shelldap index b661478..a330daf 100755 --- a/shelldap +++ b/shelldap @@ -2608,13 +2608,14 @@ sub save_config { my $confpath = shift; - my %conf2 = %$conf; - if( $confpath eq $conf->{configfile}) { - delete $conf2{'configfile'} + # This check is currently unnecessary because the comparison will always + # be true, but is left here for effect of least surprise in the future. + if( defined($conf->{'configfile'}) and ($confpath eq $conf->{'configfile'})) { + delete $conf->{'configfile'} } - YAML::Syck::DumpFile( $conf->{'configfile'}, \%conf2 ); - chmod 0600, $conf->{'configfile'}; + YAML::Syck::DumpFile( $confpath, $conf ); + chmod 0600, $confpath; return 1; }