# HG changeset patch # User Davor Ocelic # Date 1556904234 -7200 # Node ID ce001854d4b890b9106168cf69cb849a2caee065 # Parent 32f396697fb31ac6aa7d777f98fe25f6b44755e4 Improve save_config() diff -r 32f396697fb3 -r ce001854d4b8 shelldap --- a/shelldap Tue Apr 30 12:07:28 2019 +0200 +++ b/shelldap Fri May 03 19:23:54 2019 +0200 @@ -2608,13 +2608,14 @@ { my $confpath = shift; - my %conf2 = %$conf; - if( $confpath eq $conf->{configfile}) { - delete $conf2{'configfile'} + # This check is currently unnecessary because the comparison will always + # be true, but is left here for effect of least surprise in the future. + if( defined($conf->{'configfile'}) and ($confpath eq $conf->{'configfile'})) { + delete $conf->{'configfile'} } - YAML::Syck::DumpFile( $conf->{'configfile'}, \%conf2 ); - chmod 0600, $conf->{'configfile'}; + YAML::Syck::DumpFile( $confpath, $conf ); + chmod 0600, $confpath; return 1; }